Re: [PATCH v2] Add VM info to improve error log message for qemu monitor

On Tue, 4 Jan 2022, Rohit Kumar wrote: > On 03/01/22 7:12 pm, Ani Sinha wrote: > > On Wed, 22 Dec 2021, Rohit Kumar wrote:

> > > @@ -694,6 +702,7 @@ qemuMonitorOpenInternal(virDomainObj *vm, > > > mon->fd = fd; > > > mon->context = g_main_context_ref(context); > > > mon->vm = virObjectRef(vm); > > > + mon->domainName = g_strdup(vm->def->name); > > do not forget to g_free() this during cleanup in the same function. > So, in cleanup: qemuMonitorDispose is called. And there I have added g_free() > to clean mon->domainName. No, in cleanup, I see qemuMonitorClose() is called where do you do not add any additional code to free the allocation. This is what I see in cleanup code: ``` cleanup: /* We don't want the 'destroy' callback invoked during * cleanup from construction failure, because that can * give a double-unref on virDomainObj *in the caller, * so kill the callbacks now. */ mon->cb = NULL; /* The caller owns 'fd' on failure */ mon->fd = -1; qemuMonitorClose(mon);