Re: [PATCH v7 0/2] remove sysconfig files
On Fri, Jan 07, 2022 at 11:20:54AM -0700, Jim Fehlig wrote:
On 1/7/22 09:55, Andrea Bolognani wrote:
> The concerns mentioned here have not been addressed:
>
> https://listman.redhat.com/archives/libvir-list/2022-January/msg00021.html
I looked at that thread again and want to verify what is missing. IIUC, you
agreed the '--listen' comment is not needed in the service file since it is
well documented in the manpage, etc.
Yes.
WRT libvirt-guests, Olaf added the comments for each env setting to
the top
of the script. I guess what is missing is your request for a comment in the
service file telling where to look? I.e. the following part?
[Service]
# To learn what configuration knobs are available for this
# service, check out the top of the libvirt-guest.sh script
...
That's the main part, yes. I also suggested that the configuration
bits be moved to the very top of the libvirt-guest.sh script, right
after the license blurb, so that they're more visible, but that's not
quite as important as having a well-documented path from the service
file, where settings have to be applied, to the script, which is the
only source of documentation for them.
--
Andrea Bolognani / Red Hat / Virtualization