Re: [libvirt] [PATCH] tests: PCI controller checks

On 07/22/2013 08:48 AM, Ján Tomko wrote: > Check if PCI bridges with duplicate indexes are rejected. > PCI root controllers with non-zero indexes or addresses should > also be rejected. > --- > .../qemuxml2argv-pci-bridge-duplicate-index.xml | 16 ++++++++++++++++ > tests/qemuxml2argvdata/qemuxml2argv-pci-root-address.xml | 16 ++++++++++++++++ > .../qemuxml2argv-pci-root-nonzero-index.xml | 14 ++++++++++++++ > tests/qemuxml2argvtest.c | 6 ++++++ > 4 files changed, 52 insertions(+) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-bridge-duplicate-index.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-root-address.xml > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-root-nonzero-index.xml ACK. Adding test cases is always safe, even in freeze.