Re: [libvirt] [PATCH 3/3] Do not check for pkcheck
On Wed, 2018-03-07 at 10:29 +0100, Ján Tomko wrote:
[...]
+ dnl All we need to talk to polkit is DBus, no need to check
+ dnl for anything else.
The correct name is D-Bus, here and in the commit message.
Also, the second part of the comment ("no need...") doesn't
add any useful information, so just drop it.
Though you dropped $PKCHECK_PATH here, at the end of the file
there's still
AC_DEFUN([LIBVIRT_RESULT_POLKIT], [
msg="$PKCHECK_PATH (version 1)"
LIBVIRT_RESULT([polkit], [$with_polkit], [$msg])
])
Drop both setting and using $msg please.
With the above taken care of,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization