Re: [libvirt] [PATCH 0/3] Rework of SCSI host pool patch
On Mon, Mar 02, 2009 at 02:41:10PM -0500, David Allan wrote:
These three patches contain a rework of the SCSI host storage pool
patch. The rework extracts the LUN discovery code from the iSCSI
backend and generalizes it be be usable by both the SCSI and iSCSI
backends. The first patch is the one I submitted last week that
contains a port of Dan's HAL code into the current tree. The
second is the rework, and the third is the removal of the HAL
dependencies from the build system.
In addition to whatever feedback people have, I'd like help
regression testing iSCSI pools. I have tested on my machine,
but it should have a little additional run time before commit.
One change that results from the new way of discovering logical
units is that LUs on iSCSI hosts will not be discovered by the
SCSI host pool code--i.e., they have to be discovered as iSCSI
sessions. I'm not terribly happy about that--it's a result of
the way the entries in sysfs appear, so I'm going to think
about that some more, but I wanted to get the first cut out to
people for feedback today.
I don't think its a huge problem that you can't scan iSCSI LUs
via the SCSI pool. The only case that'd be needed is if you had
setup the iSCSI connections outside the context of libvirt, but
even then our iSCSI pool impl is happy to enumerate an existing
logged in iSCSI target.
From a testing POV the most important thing is to try it out on a
variety of kernel versions - eg RHEL-5 2.6.18, and Fedora 9/10/11
since sysfs has been known to change over time.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|