Re: [libvirt] [PATCH v2 RESEND 01/12] conf: Add definitions for 'uid' and 'fid' PCI address attributes

24 Jul 2018


      On Tue, 2018-07-10 at 16:02 +0800, Yi Min Zhao wrote:
...
struct _virPCIDeviceAddress {
     unsigned int domain;
     unsigned int bus;
     unsigned int slot;
     unsigned int function;
     int multi; /* virTristateSwitch */
+    virZPCIDeviceAddressPtr zpci;
This should probably be an embedded structure rather than a pointer
to a separate, heap allocated structure.

I remember Laine having somewhat strong feelings about the topic,
so I'll leave arguing for or against that to him :)

-- 
Andrea Bolognani / Red Hat / Virtualization