Re: [libvirt] [PATCH 2/4] libvirt-guest.init: quoting variables

> Meanwhile, I'm not a fan of blindly quoting everything; there are > documented cases where you can trigger shell bugs by doing too much > quoting. For example: > > foo=`some_command "with quotes"` > > is portable, but > > foo="`some_command "with quotes"`" > > is not. So I prefer to quote variables that come from external source, > but not internal variables that are obviously safe (that said, quoting > generally doesn't hurt, so even if something is overkill does not meant > that I am rejecting the patch). I've seen to many scripts not doing any quoting at all or all wrong, which fail in interesting to horrible ways when given arguments containing shell meta characters. I personally consider them a much greater risk than some ancient shell not being able to parse properly quoted strings.