Re: [libvirt] [PATCH] qemu: fix UNIX socket chardevs operating in client mode
On Fri, Jul 06, 2018 at 12:12:51PM +0100, Richard W.M. Jones wrote:
On Fri, Jul 06, 2018 at 11:03:00AM +0100, Daniel P. Berrangé wrote:
> When support was adding for passing a pre-opened listener socket to UNIX
> chardevs, it accidentally passed the listener socket for client mode
> chardevs too with predictable amounts of fail resulting.
>
> Expand the unit test coverage to validate that we are only doing FD
> passing when operating in server mode.
>
> Reported-by: Richard W.M. Jones <rjones(a)redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
I suppose you might want to mention in the commit message that the bug
only affects qemu 2.12, and the bug number (1598440).
Anyhow, I tested this patch and it fixes the problem, so:
Tested-by: Richard W.M. Jones <rjones(a)redhat.com>
Thanks, added that info and push it.
There is a scratch build for Rawhide containing the patch here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=28050872
Note that the patch requires quite a bit of adjustment to apply and
build against 4.5.0. I wasn't at all confident that I've done it
right so I didn't push anything to Rawhide. It'd be good to have this
fix in Rawhide & RHEL 7 asap though.
It just needs the 3 prior patches including first. I've added those all
to Fedora rawhide.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|