On 06/08/2010 02:42 PM, Jiri Denemark wrote:
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 19d5205..c806441 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -121,7 +121,8 @@ typedef virDomainInfo *virDomainInfoPtr; * Domain. */ typedef enum { - VIR_DOMAIN_NONE = 0 + VIR_DOMAIN_NONE = 0, /* Default behavior */ + VIR_DOMAIN_START_PAUSED = 0 << 1, /* Launch guest in paused state */ } virDomainCreateFlags;
I believe, you wanted to write 1 << 0 as a value of VIR_DOMAIN_START_PAUSED, didn't you?
Blame the fact that I was traveling yesterday? Yes, a bone-headed bug on my part; thanks for catching it, and thank goodness for the review process.
The rest of this patch looks just fine to me, ACK.
Fixed, and will push as soon as I actually complete some testing on 2/3 and 3/3 (which would have prevented posting this bug in the first place).
Jirka
-- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org