Re: [libvirt] [PATCH 08/12] qemu-command: Move qemuDomain*Address* functions to qemu_domain.c

On Mon, Feb 15, 2016 at 02:37:22PM -0500, John Ferlan wrote:

Move the functions into qemu_domain.c - additionally move any supporting static functions.

Make qemuDomainSupportsPCI non static.

Also, move and rename the following:

qemuSetSCSIControllerModel to qemuDomainSetSCSIControllerModel qemuCollectPCIAddress to qemuDomainCollectPCIAddress qemuValidateDevicePCISlotsPIIX3 to qemuDomainValidateDevicePCISlotsPIIX3 qemuAssignDevicePCISlots to qemuDomainAssignDevicePCISlots

Most of these deal with domain addresses and qemu_domain.c is growing pretty large. I think they deserve a qemu_domain_addr.c module. (On the other hand, strictly sticking to the qemuDomainAddr prefix will make the function names too long) Jan