Re: [libvirt] [jenkins-ci PATCH v3 01/12] jobs: Rename git-url -> git_url
On Wed, 2018-08-22 at 12:19 +0200, Erik Skultety wrote:
On Wed, Aug 22, 2018 at 11:44:16AM +0200, Andrea Bolognani wrote:
> Other user-defined variables use underscores as
> separator instead of dashes; this change will also
> help us out later.
There are variables like child-workspace, block-upstream, days-to-keep, etc. in
most of the templates under jobs/ which would fancy a similar care since you're
striving for consistency in variable naming here. Anyway, I'm quite ambivalent
about the patch, I don't mind having it in, but I don't feel like this is the
kind of change we want to merge. Having said that though, there already are
commits like that, so my argument is invalid.
If you show some love to the other variables which suffer from the same
"plague" too:
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
Note "user-defined" above: all the other names you mentioned are
part of JJB's own grammar for defining jobs, so we couldn't change
them even if we wanted to.
Perhaps I should have expanded the "help us out later" bit in the
commit message to explain that this is not a gratuitous change
made just to satisfy my craving for consistency[1]: while JJB is
okay with user variables having dashes is them, Ansible is very
much not, and if you look ahead to patch 06/12 you'll see why
keeping the existing name would just not work - hence this patch.
[1] Though I'll admit I'm absolutely not above doing that ;)
--
Andrea Bolognani / Red Hat / Virtualization