Re: [PATCH 00/22] Fix hotplug of disks with iothreads and s390 cruft cleanup

This series consists of 3 parts: Part 1, patches 1-3: These are fixes to the virCommand->string conversion, namely two bugs: - VIR_TEST_REGENERATE_OUTPUT would produce new files with missing end newline - memleak in bhyves xml->native conversion Part 2, patches 4 - 21: Removal of 's390-virtio' machine and the corresponding addressing type. This was removed in qemu 2.6. The exploration started because the last patch was for a strange reason checking the address type and I needed to know if indeed 'virtio-s390' addresses don't support iothreads. Turns out the whole thing can be deleted. Part 3, patch 22: Hotplug of disks with iothreads is broken because the code was moved prior to address asignment and didn't account for missing address. Let's remove the whole check as it turned out to be pointless. Peter Krempa (22): util: command: Introduce virCommandToStringBuf qemuxml2arvtest: Ensure newline at the end of generated .args files bhyveConnectDomainXMLToNative: Fix memory leak in incorrect virCommandToString usage tests: qemuxml2argv: Modernize 'watchdog-diag288' test tests: qemuxml2argv: Modernize 'console-sclp' test tests: qemuxml2argv: Remove redundant tests for the obsolete 'virtio-390' machine tests: qemuxml2argv: Modernize 's390-allow-bogus-usb-none' test tests: qemuxml2xml: Modernize 's390-defaultconsole' case tests: qemuxml2argv: Modernize 's390-allow-bogus-usb-controller' test qemu: domain: Remove hack for 's390-virtio' machine tests: Remove 's390-virtio' machine caps faking qemu: capabilities: Remove probing of 'virtio-*-s390' devices qemu: capabilities: Don't probe device properties for 'virtio-*-s390' devices qemuxml2argvtest: Use other bus capability for 'non-x86_64-timer-error' case qemu: Always reject 'virtio-s390' addresses qemu: Remove last uses of QEMU_CAPS_VIRTIO_S390 qemuxml2*test: Remove QEMU_CAPS_VIRTIO_S390 flag qemu: capabilities: Retire QEMU_CAPS_VIRTIO_S390 qemu: Drop handling of devices with VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390 qemuValidateDomainDeviceDefAddress: Add validation of CCW address qemuDomainCheckCCWS390AddressSupport: Remove duplicated checker qemu: validate: Don't check bus type in qemuValidateDomainDeviceDefDiskIOThreads src/bhyve/bhyve_driver.c | 4 +- src/libvirt_private.syms | 1 +

tests/testutilsqemu.c | 2 +- tests/vircapstest.c | 4 - 74 files changed, 2562 insertions(+), 3387 deletions(-) delete mode 100644 tests/qemuxml2argvdata/console-sclp.args create mode 100644 tests/qemuxml2argvdata/console-sclp.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/console-virtio-s390.args delete mode 100644 tests/qemuxml2argvdata/console-virtio-s390.xml delete mode 100644 tests/qemuxml2argvdata/disk-virtio-s390.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-s390.xml delete mode 100644 tests/qemuxml2argvdata/net-virtio-s390.args delete mode 100644 tests/qemuxml2argvdata/net-virtio-s390.xml delete mode 100644 tests/qemuxml2argvdata/s390-allow-bogus-usb-controller.args create mode 100644 tests/qemuxml2argvdata/s390-allow-bogus-usb-controller.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/s390-allow-bogus-usb-none.args create mode 100644 tests/qemuxml2argvdata/s390-allow-bogus-usb-none.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/watchdog-diag288.args create mode 100644 tests/qemuxml2argvdata/watchdog-diag288.s390x-latest.args rename tests/qemuxml2xmloutdata/{s390-defaultconsole.xml => s390-defaultconsole.s390x-latest.xml} (82%)