Re: [libvirt PATCH] esx: Same order of arguments in definition and declaration
On Sun, Feb 23, 2020 at 12:22:25AM +0100, Rikard Falkeborn wrote:
The order of arguments were not the same in the definition and
declaration. All callers use the same order as the definition, so there
is no bug, but change the function declaration to match the
implementation to avoid confusion.
Did you find it visually, or using cppcheck? :)
Signed-off-by: Rikard Falkeborn <rikard.falkeborn(a)gmail.com>
---
src/esx/esx_vi.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
and pushed. Congrats on your first patch!
Jano
Attachments:
- signature.asc (application/pgp-signature — 488 bytes)