Re: [libvirt] [PATCH] * configura.ac, spec file: firewalld now defaults to enabled, depends on dbus * fixed comment for with_firewalld define * bridge_driver, nwfilter_driver: new dbus filters to get FirewallD1.Reloaded signal and DBus.NameOwnerChanged on org.fedoraproject.FirewallD1 * iptables, ebtables, nwfilter_ebiptables_driver: use firewall-cmd direct passthrough interface * spec file changed as requested

On 08/13/2012 01:23 PM, Thomas Woerner wrote: Subject line was a mess. You forgot a one-line summary followed by a blank line before the actual listing of changes you made. Also, by replying in a thread, it's not clear whether this is a new patch unrelated to the rest of the thread, or a resubmission. Using 'git send-email --subject-prefix=PATCHv2' will help on that front. Can you please submit a new version with fixed subject, and perhaps as a standalone thread to make it easier to spot? Also, these findings need fixing: Needs a fourth argument to AC_ARG_WITH to set the default when neither '--with-firewalld' nor '--without-firewalld' is given. We tend to prefer tri-state checking (yes, no, and 'check', with the default being check, and where check changes to yes or no depending on finding prerequisites in place). Also, at the end of configure.ac, we have a series of outputs that summarize what was selected; firewalld should be listed in that summary. Long line. I'd wrap at the comma between 'connection ATTRIBUTE_UNUSED, DBusMessage'. -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org