Re: [libvirt] [PATCH 6/8] backup: Add support for filtering based on current moment

On 7/8/19 3:27 AM, Peter Krempa wrote: For now, I'm deferring this patch to later (or maybe even dropping it), based on the v9 review comments about using the one-and-only leaf node snapshot as the default parent at least for the short term where we interlock against having snapshots. If we find that changing a checkpoint current node makes sense with snapshots, we can always add additional filtering at that time, but right now is premature. While it is more churn for me, I agree with the goal of stripping down the initial implementation to the bare minimum needed, and this does not qualify in that regards. Because if we like the idea of filtering on a current node better than the idea of no_metadata, then patches that add current filtering in v9 use bit 6 right away, while bits for metadata filtering of checkpoints sit unused, and it looks odd to have a gap in the numbering. The snapshot code already has to do mapping between internal bits from the public API flags, but my initial goal was to have the internal bits match the checkpoint public bits. That said, since I'm now working on stripping the notion of current filtering out of checkpoints before the initial implementation, the question is moot until (or if) this patch ever gets revived. Thanks for the review, even if later patches changed our minds. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org