Re: [libvirt] [PATCH 0/4] support the listenNetwork attribute in <graphics>
On 07/07/2011 12:44 AM, Laine Stump wrote:
This patch series resolves the following bug:
https://bugzilla.redhat.com/show_bug.cgi?id=703851
In short, it implements support for a new "listenNetwork" attribute in
the domain's<graphics> element. When listenNetwork is specified,
libvirt will look for a network of that name (from the networks that
can be created within libvirt), and derive a listen address from the
physical interface used to connect that network to the outside
world. (More details are given in each commit message).
I guess it's not possible to reuse the existing 'listen' attribute, by
doing context-sensitive parsing to allow either ip address or a network
name, because 'listen' already supports host names which get resolved
into an ip address.
I haven't looked at the series in detail, so maybe that will help me
think of a possibly better attribute name.
Note that I'm not particularly fond of the attribute name (it's too
long and has the ugly capital letter in the middle). If anyone has a
suggestion for something better, please give your opinion now, before
it's pushed and becomes permanent!
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org