Re: [libvirt] Updated James Morris patch to apply to libvirt-0.6.0 version

Daniel P. Berrange wrote:

Just spotted one serious problem we need to address. The method 'qemudStartVMDaemon' quoted here is where we set the security label: ...

Good catch.

To use this, we'd make qemudStartVM() pass in a virExecHook callback which does the call to qemudDomainSetSecurityLabel()

Daniel

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -291,6 +291,7 @@ virEnumToString; virEventAddHandle; virEventRemoveHandle; virExec; +virExecWithHook;

Looks right to me. ACK.