On Mon, Jan 17, 2022 at 02:17:10PM +0100, Michal Prívozník wrote:
On 1/17/22 14:09, Andrea Bolognani wrote:
On Mon, Jan 17, 2022 at 01:39:31PM +0100, Michal Prívozník wrote:
And what exactly is the point? I'm failing to see why this would be any better than mocking virCommand. Can you elaborate please?
I believe the diffstats speak for themselves :)
$ git diff --stat df09e45310..64325fa9ef tests/networkmock.c | 16 ++++++++++++++++ tests/networkxml2conftest.c | 38 +++++++++++++++++++++++++++++++++++++- 2 files changed, 53 insertions(+), 1 deletion(-)
$ git diff --stat df09e45310..2b64fb492b tests/networkmock.c | 2 +- tests/networkxml2conftest.c | 2 +- tests/virdnsmasqmock.py | 14 ++++++++++++++ 3 files changed, 16 insertions(+), 2 deletions(-)
Alright, let's switch to python. I'm starting to not care about these patches fate so I won't object.
If you don't feel like doing that, you can consider your original patch Reviewed-by: Andrea Bolognani <abologna@redhat.com> and I'll try the script approach myself as a follow-up. -- Andrea Bolognani / Red Hat / Virtualization