Daniel P. Berrange wrote:
On Tue, Sep 15, 2015 at 09:26:23AM -0600, Jim Fehlig wrote:
Instead of a hardcoded DEBUG log level, use the overall daemon log level specified in libvirtd.conf when opening a log stream with libxl. libxl is very verbose when DEBUG log level is set, resulting in huge log files that can potentially fill a disk. Control of libxl verbosity should be placed in the administrator's hands.
Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- src/libxl/libxl_conf.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
ACK, this makes sense as default behaviour. As a future enhancement you might also consider supporting a config setting in /etc/libvirt/libxl.conf to explicitly control the libxl library logging behaviour independantly.
I had actually thought of adding it there first, but then took this approach assuming it would be more receptive upstream :-). Personally, I'm on the fence. I like the idea of a single knob to control log level throughout the daemon, making it a bit easier on admins. On the other hand, individual knobs are more friendly to those pouring through logs. I can add a knob in libxl.conf if preferred. Regards, Jim