Re: [libvirt] [PATCH v2] qemu: process: Improve update of maximum baloon state at startup

s/baloon/balloon/ in the subject On Wed, Jul 01, 2015 at 10:13:27AM +0200, Peter Krempa wrote: > In commit 641a145d73fdc3dd9350fd57b3d3247abf101c05 I've added code that > resets the ballon memory value to full size prior to resuming the vCPUs s/ballon/balloon/ > since the size certainly was not reduced at that point. > > Since qemuProcess start is used also in code paths with already booted qemuProcessStart > up guests (migration, save/restore) the assumption is not entirely true > since the guest might already been running before. > > This patch adds a function that queries the monitor rather than using > the full size since a balloon event would not be reissued in case we are This one is fine. > recovering a saved migration state. > > Additionally the new function is used also when reconnecting to a VM > after libvirtd restart since we might have missed a few ballon events s/ballon/balloon/ > while libvirtd was not running. > --- > src/qemu/qemu_process.c | 38 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 37 insertions(+), 1 deletion(-) > > diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c > index ba84182..13b1696 100644 > --- a/src/qemu/qemu_process.c > +++ b/src/qemu/qemu_process.c > @@ -2065,6 +2065,38 @@ qemuProcessReconnectRefreshChannelVirtioState(virQEMUDriverPtr driver, > > > static int > +qemuProcessRefreshBallonState(virQEMUDriverPtr driver, s/Ballon/Balloon/ > + virDomainObjPtr vm, > + int asyncJob) > +{ > + unsigned long long balloon; > + int rc; > + > + /* if no balloning is available, the current size equals to the current s/ballon/balloon/ ACK with the subject and the function name fixed.