On Sun, Apr 19, 2015 at 20:49:09 -0400, John Ferlan wrote:
Prior to attempting to open the gluster connection, let's make sure we can resolve the source pool hostname.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/storage/storage_backend_gluster.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/src/storage/storage_backend_gluster.c b/src/storage/storage_backend_gluster.c index d2e79bc..e3a8c21 100644 --- a/src/storage/storage_backend_gluster.c +++ b/src/storage/storage_backend_gluster.c @@ -96,6 +96,9 @@ virStorageBackendGlusterOpen(virStoragePoolObjPtr pool) trailing_slash = false; }
+ if (!virIsValidHostname(pool->def->source.hosts[0].name)) + return NULL; +
Okay, it might be marginally worth at this point, since gluster is/was leaking some memory and threads after it was initialized. On the other hand you'll be resolving the hostname again a few lines below.
if (VIR_ALLOC(ret) < 0) return NULL;
Peter