Re: [libvirt] [PATCH v5 16/16] qemu: Use switch statement for address types in qemuBuildControllerDevStr

On 01/06/2018 12:47 AM, John Ferlan wrote:

From: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>

Use a switch statement instead of if-else-if statements. Move the command line building of the iothread attribute into the common path as the SCSI controller attributes are already validated.

Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com> Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/qemu/qemu_command.c | 45 +++++++++++++++++++++++++-------------------- 1 file changed, 25 insertions(+), 20 deletions(-)

ACK Michal