On 03/18/2014 09:25 AM, Eric Blake wrote:
On 03/18/2014 07:36 AM, Daniel P. Berrange wrote:
The CMD_STOPONERR macro uses its parameter as a boolean, so should be passed true rather than 1.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/nwfilter/nwfilter_ebiptables_driver.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-)
Umm, ALL callers of CMD_STOPONERR pass 1 (now true). Why not just delete the parameter altogether?
Oh, never mind. Patch 3/6 was missing in my inbox (but I see it in list archives - wonder why some messages are getting delayed), but with that patch, I see uses of CMD_STOPONERR(stopOnError), so we DO pass false in some places. ACK as-is. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org