Re: [libvirt] [PATCH] properly set video ram size for qemu VGA video device

On 07/07/2014 01:44 PM, Pavel Hrdina wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1076098 > > We support vram option for video devices in domain xml, but so far > only for QXL it had some effect. VGA video device in QEMU can also > accept the size of video ram and we should pass it. > Even if vram is 9 MB as we made up in virDomainVideoDefaultRAM? IMO we should either treat 9 MB as "use the default" and not pass it to QEMU, or just hide the 'vram' attribute (just for the 'weird 9 MB default' cards and QEMU domains) from non-migratable XML and use a new attribute. BTW, there were also patches proposing a new attribute: https://www.redhat.com/archives/libvir-list/2014-June/msg00565.html

> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > src/qemu/qemu_command.c | 3 +++ > 1 file changed, 3 insertions(+) Documentation and tests are missing. > > diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c > index fb64cda..09e29c9 100644 > --- a/src/qemu/qemu_command.c > +++ b/src/qemu/qemu_command.c > @@ -4800,6 +4800,9 @@ qemuBuildDeviceVideoStr(virDomainDefPtr def, > > /* QEMU accepts bytes for vram_size. */ > virBufferAsprintf(&buf, ",vram_size=%u", video->vram * 1024); > + } else if (video->type == VIR_DOMAIN_VIDEO_TYPE_VGA) { VMVGA has vgamem_mb too. Don't we also need a new qemu capability to probe if this is supported by the QEMU binary? > + /* QEMU accepts megabytes for vgamem_mb. */ > + virBufferAsprintf(&buf, ",vgamem_mb=%u", video->vram / 1024); > } > > if (qemuBuildDeviceAddressStr(&buf, def, &video->info, qemuCaps) < 0) > Jan -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list