Re: [libvirt] PATCH 2/4: AppArmor updates
On Mon, 2010-08-16 at 17:14 +0100, Daniel P. Berrange wrote:
You can't blindly de-reference data.file.path - The
'file' struct
is inside a union and is only valid for certain types of character
device VIR_DOMAIN_CHR_TYPE_PTY, TYPE_DEV, TYPE_FILE and TYPE_PIPE.
The existing code for serial devices is broken too & can crash due
to this
Hrmm. I always did it this. Maybe something changed and I missed it.
Regardless, thanks for this feedback! :) Attached is an updated patch.
--
Jamie Strandboge | http://www.canonical.com
Attachments:
- signature.asc (application/pgp-signature — 198 bytes)
- 0002-apparmor-chardev.patch (text/x-patch — 5.2 KB)