Re: [libvirt] [PATCH 0/5] libxl: improve xl config parsing

On 20.03.2015 18:07, Jim Fehlig wrote: > This series was inspired by Marek's and Chunyan's patches to add support > for <kernel>, <initrd>, and <cmdline> in Xen HVM domain config > > https://www.redhat.com/archives/libvir-list/2015-March/msg00328.html > https://www.redhat.com/archives/libvir-list/2014-September/msg01006.html > > Patches 1 and 2 are trivial prep for patch 3, which moves parsing and > formatting of <os> config out of the common code and into the xl and xm > specfic parsing/formatting code. For ease of review, identical copies > of xen{Parse,Format}OS are made in xen_{xl,xm}.c. Changes to the xl > parsing/formatting functions are made in patch 4 and 5. > > Changing the order in which config is parsed/formatted has the > unfortunate side affect of requiring corresponding changes to the > test config data files. Patch 3 shoulders that burden. > > Jim Fehlig (5): > xenconfig: export xenConfigCopyString > xenconfig: remove redunant parsing of device_model > xenconfig: move <os> parsing/formating to config-specific files > xenconfig: don't use "kernel" for hvmloader > libxl: support HVM direct kernel boot > > src/libxl/libxl_conf.c | 9 ++ > src/xenconfig/xen_common.c | 146 +---------------- > src/xenconfig/xen_common.h | 5 + > src/xenconfig/xen_xl.c | 178 +++++++++++++++++++++ > src/xenconfig/xen_xm.c | 141 ++++++++++++++++ > tests/testutilsxen.c | 8 +- > .../test-fullvirt-direct-kernel-boot.cfg | 29 ++++ > .../test-fullvirt-direct-kernel-boot.xml | 49 ++++++ > tests/xlconfigdata/test-fullvirt-multiusb.cfg | 5 +- > tests/xlconfigdata/test-new-disk.cfg | 5 +- > tests/xlconfigdata/test-spice.cfg | 5 +- > tests/xlconfigtest.c | 3 + > tests/xmconfigdata/test-escape-paths.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-force-hpet.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-force-nohpet.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-localtime.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-net-ioemu.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-net-netfront.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-new-cdrom.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-old-cdrom.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-parallel-tcp.cfg | 6 +- > .../test-fullvirt-serial-dev-2-ports.cfg | 6 +- > .../test-fullvirt-serial-dev-2nd-port.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-serial-file.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-serial-null.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-serial-pipe.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-serial-pty.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-serial-stdio.cfg | 6 +- > .../test-fullvirt-serial-tcp-telnet.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-serial-tcp.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-serial-udp.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-serial-unix.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-sound.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-usbmouse.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-usbtablet.cfg | 6 +- > tests/xmconfigdata/test-fullvirt-utc.cfg | 6 +- > tests/xmconfigdata/test-no-source-cdrom.cfg | 6 +- > tests/xmconfigdata/test-paravirt-net-e1000.cfg | 2 +- > tests/xmconfigdata/test-paravirt-net-vifname.cfg | 2 +- > .../test-paravirt-new-pvfb-vncdisplay.cfg | 2 +- > tests/xmconfigdata/test-paravirt-new-pvfb.cfg | 2 +- > .../test-paravirt-old-pvfb-vncdisplay.cfg | 2 +- > tests/xmconfigdata/test-paravirt-old-pvfb.cfg | 2 +- > tests/xmconfigdata/test-paravirt-vcpu.cfg | 2 +- > tests/xmconfigdata/test-pci-devs.cfg | 6 +- > 45 files changed, 511 insertions(+), 242 deletions(-) > create mode 100644 tests/xlconfigdata/test-fullvirt-direct-kernel-boot.cfg > create mode 100644 tests/xlconfigdata/test-fullvirt-direct-kernel-boot.xml > ACK although you will have to rebase the last patch.