Re: [libvirt] PATCH: Add NUMA info to QEMU driver

On Tue, May 20, 2008 at 02:15:59PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > > This patch includes NUMA topology info in the QEMU driver capabilities > > XML output. It also implements the free memory driver APIs. This is done > > with the LGPL'd numactl library. The configure script probes for it and > > only enables this functionality if it is found. The numactl library has > > been around for quite a while - RHEL-3 vintage at least > > Looks fine, modulo a few nits... > > ... > > + for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++) > > + if ((mask[(i / MAX_CPUS_MASK_SIZE)] >> (i % MAX_CPUS_MASK_SIZE)) & 1) > ... > > + for (ncpus = 0, i = 0 ; i < MAX_CPUS ; i++) > > + if ((mask[(i / MAX_CPUS_MASK_SIZE)] >> (i % MAX_CPUS_MASK_SIZE)) & 1) > > The above bit-is-set query deserves a macro. Here's a update with that macro-ized, and the stupid fprintf()'s that rich noticed removed.