Re: [libvirt PATCH 1/2] docs: Convert existing tables to list-table
On Thu, May 07, 2020 at 14:04:44 +0100, Daniel Berrange wrote:
On Thu, May 07, 2020 at 02:46:38PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> docs/coding-style.rst | 53 +++++++++++-------
> docs/glib-adoption.rst | 123 +++++++++++++++++++++++++++--------------
> 2 files changed, 114 insertions(+), 62 deletions(-)
>
> diff --git a/docs/glib-adoption.rst b/docs/glib-adoption.rst
> index 62ddd7c61d..a5dca47f5e 100644
> --- a/docs/glib-adoption.rst
> +++ b/docs/glib-adoption.rst
> @@ -53,44 +53,85 @@ The following libvirt APIs have been deleted already:
> ``VIR_STRDUP``, ``VIR_STRNDUP``
> Prefer the GLib APIs ``g_strdup`` and ``g_strndup``.
[...]
I'm wondering how long we actually need to bother keeping this text,
given that it is talking about stuff we've already deleted.
IMO we can purge those which don't have the definition present, which
looks like it's all of them.
Also when grepping random entries I've found that we mention VIR_STRDUP
in a syntax check.