Re: PATCH v2: Implement NFS Protocol
On Wed, Jan 06, 2021 at 15:32:25 -0600, Ryan Gahagan wrote:
Per Issue 90[1], QEMU supports using an NFS disk but Libvirt had no
support for attaching a disk of this type. This patch series adds in
this capability as well as the tests necessary to make sure it works
correctly.
The changes in this second version over the previous patch series for
this issue primarily address feedback. Documentation was updated and the
XML <nfs> element has been renamed as an <identity> element. The code
for checking user XML for an NFS protocol has been relocated to the
validation method and other pieces of code were refactored per
suggestion. Tests have been altered to reflect the new XML element and
the fact that NFS does not allow hosts to have a port.
References:
[1]: https://gitlab.com/libvirt/libvirt/-/issues/90
We usually prefer if you describe what you are adding in the actual
commit messages since they are recorded in git history instead of the
cover letter which gets forgotten.
Anyways.
Series:
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
I'll fix the one problem pointed out in the specific commit and I'll
push the patches later today.