Re: [libvirt] [PATCH 1/7] cpu: Add support for loading and storing CPU data
On Tue, Jul 23, 2013 at 06:11:30PM +0200, Jiri Denemark wrote:
Could use a more verbose commit message.
Looking at later patches, I see cpuDataFormat used in the
test suite, but I don't see cpuDataParse used anywhere ?
If these are only for the test suite, then perhaps adding
them to a cpupriv.h header is preferrable.
---
src/cpu/cpu.c | 41 ++++++++++++++
src/cpu/cpu.h | 13 +++++
src/cpu/cpu_x86.c | 135 +++++++++++++++++++++++++++++++++++++++--------
src/libvirt_private.syms | 2 +
4 files changed, 170 insertions(+), 21 deletions(-)
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|