Re: [libvirt] [PATCH 1/3] qemuhotplugtest: Allow testing of live data

On 03/30/2016 11:13 AM, Martin Kletzander wrote: > For now, the test was dumping an XML of inactive domain (well, setting > the id to '-1' to be precise) when checking the results. This patch > enables future additions to test the live XML output as well. > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > tests/qemuhotplugtest.c | 27 +++++++++++++++++---------- > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c > index 1eb2b6a881f2..2b0de94fb4a6 100644 > --- a/tests/qemuhotplugtest.c > +++ b/tests/qemuhotplugtest.c > @@ -371,7 +374,7 @@ mymain(void) > /* wait only 100ms for DEVICE_DELETED event */ > qemuDomainRemoveDeviceWaitTime = 100; > > -#define DO_TEST(file, ACTION, dev, event, fial, kep, ...) \ > +#define DO_TEST(file, ACTION, dev, event, fial, kep, liv, ...) \ "Typically" rather than misspelling "fail", "keep", or "live" one would use an underscore, such as "_fail", "_keep", and "_live" in order to represent a macro argument... Not required for ACK, but nice nonetheless