Re: [libvirt] [PATCH 4/6] Also create the USB address cache for domains with all the USB addresses
$SUBJ...
The "Also" just seems misplaced.
especially with the "Also generate the..." below...
How about "At Reconnect, recreate the USB address cache"
?
On 10/21/2016 09:58 AM, Ján Tomko wrote:
When starting a new domain, we allocate the USB addresses and keep
an address cache in the domain object's private data.
However this data is lost on libvirtd restart.
The qemuProcessReconnect will call qemuDomainAssignAddresses w/
newDomain = false, so this code needs to "repopulate" the usbaddr cache
properly, but can only properly do so if all the USB addresses for the
domain were specified in the domain XML.
In this path are we getting the status XML file which "should" have all
the addresses, right?
Also generate the address cache if all the addresses have been
specified, so that devices hotplugged after libvirtd restart
also get theirs assigned.
https://bugzilla.redhat.com/show_bug.cgi?id=1387666
---
src/conf/domain_addr.c | 12 ++++++++++++
src/conf/domain_addr.h | 4 ++++
src/libvirt_private.syms | 1 +
src/qemu/qemu_domain_address.c | 16 ++++++++++++++--
4 files changed, 31 insertions(+), 2 deletions(-)
ACK for the patch, just validating/checking my assumptions on the commit
message.
John