Re: [libvirt] [PATCH 3/5] util: Add getters for cgroup block device I/O throttling

On 08/03/2015 10:50 AM, Martin Kletzander wrote: > Since now they were not needed, but I sense they will be in a short > while. > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > src/libvirt_private.syms | 5 + > src/util/vircgroup.c | 277 ++++++++++++++++++++++++++++++++++++++++++++++- > src/util/vircgroup.h | 20 ++++ > 3 files changed, 299 insertions(+), 3 deletions(-) > > diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c > index afa85ded9061..9d527fb8b99a 100644 > --- a/src/util/vircgroup.c > +++ b/src/util/vircgroup.c > @@ -804,6 +804,36 @@ virCgroupGetValueStr(virCgroupPtr group, > > > static int > +virCgroupGetValueForBlkDev(virCgroupPtr group, > + int controller, > + const char *key, > + const char *path, > + char **value) > +{ > + char *prefix = NULL; > + char *str = NULL; > + char **lines = NULL; > + int ret = -1; > + > + if (virCgroupGetValueStr(group, controller, key, &str) < 0) > + goto error; > + > + if (!(prefix = virCgroupGetBlockDevString(path))) > + return -1; ^^^ str is leaked. (Coverity found)

> + > + if (!(lines = virStringSplit(str, "\n", -1))) > + goto error; > + > + ret = VIR_STRDUP(*value, virStringGetFirstWithPrefix(lines, prefix)); ^^^ can return NULL VIR_STRDUP(*value, NULL) ??