Re: [libvirt] [PATCH 0/4][RFC] Drop media update support in virDomainAttachDevice*
On Wed, Jan 15, 2020 at 04:24:54PM +0800, Han Han wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1788793
Before virDomainUpdateDeviceFlags, virDomainAttachDevice* were used for
media update. Now we have introduced virDomainUpdateDeviceFlags for 9
years(since commit 46a2ea3689) but keep that compatibility of
virDomainAttachDevice* until now.
I think it is time to remove the compatibility since it doesn't work as
well as virDomainUpdateDeviceFlags on disk xml validation.
I wonder if any uplayer software relying on this compatibility...
NACK, this is explicitly the kind of thing we will never do.
Providing a long term stable API means keeping existing methods
operating unchanged, even if we have since introduced a new method
which can do the same thing in a better way. The cost of keeping
this existing code is negligible in context to the maint work of
libvirt in general.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|