Re: [libvirt-ci PATCH 04/12] lcitool: Use a temporary JSON file to pass extra variables

7 May 2020

      On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote:
...
ansible_cfg_path = os.path.join(base, "ansible.cfg")
         playbook_base = os.path.join(base, "playbooks", playbook)
         playbook_path = os.path.join(playbook_base, "main.yml")
-
-        extra_vars = json.dumps({
+        extra_vars_path = os.path.join(tempdir.name, "extra_vars.json")
+        extra_vars = {
Leave the empty line between all the various paths and extra_vars.

With that changed,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization