[libvirt PATCH 5/5] vsh: secret-set-value: Mark '--base64' as deprecated
Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
---
tools/virsh-secret.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c
index 7ca3e864da..5a1c4d7bf6 100644
--- a/tools/virsh-secret.c
+++ b/tools/virsh-secret.c
@@ -192,6 +192,7 @@ static const vshCmdOptDef opts_secret_set_value[] = {
},
{.name = "base64",
.type = VSH_OT_STRING,
+ .flags = VSH_OFLAG_DEPRECATED,
.help = N_("base64-encoded secret value")
},
{.name = NULL}
@@ -225,8 +226,6 @@ cmdSecretSetValue(vshControl *ctl, const vshCmd *cmd)
return false;
if (base64) {
- /* warn users that the --base64 option passed from command line is wrong */
- vshError(ctl, _("Passing secret value as command-line argument is
insecure!"));
secret_val = g_strdup(base64);
secret_len = strlen(secret_val);
} else if (filename) {
--
2.26.2