Re: [libvirt] [Libvirt-Security] [PATCH] qemu: bulk stats: typo in monitor handling
On 12/11/2014 02:57 AM, Peter Krempa wrote:
On 12/11/14 08:44, Francesco Romani wrote:
> A typo in qemuConnectGetAllDomainStats makes the code
> mark the monitor as available when qemuDomainObjBeginJob
> fails, instead of when it succeeds, as the correct flow
> requires.
>
> This patch fixes the check and updates the code documentation
> accordingly.
Wow, nice catch. The logic inversion was introduced by the CVE fix:
Fortunately, as there has been no release in between the initial CVE fix
and this followup patch, there is no need for an additional CVE. It
merely means that the CVE fix is a two-patch effort.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 539 bytes)