17 May
2010
17 May
'10
1:34 p.m.
On 05/17/2010 11:22 AM, Jim Meyering wrote:
This addresses another coverity-spotted "flaw". However, since "cgroup" is never NULL after that initial "if" stmt, the only penalty is that the useless cleanup test would make a reviewer try to figure out how cgroup could be NULL there.
ACK.
cleanup: - if (cgroup) - virCgroupFree(&cgroup); + virCgroupFree(&cgroup);
Is this something that the useless-if-before-free test could have caught, rather than waiting for coverity? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org