On Wed, Jul 22, 2009 at 04:27:45PM +0900, Nguyen Anh Quynh wrote:
On Wed, Jul 22, 2009 at 4:19 PM, Nguyen Anh Quynh<aquynh@gmail.com> wrote: Acutally, to avoid all those ugly sanity checks, it is best to define
S/ugly/sane/
VIR_MEMORY_* as an enum type, then redefine virDomainMemoryCheck() as (note the last param is changed):
int virDomainMemoryPeek (virDomainPtr dom, unsigned long long start, size_t size, void *buffer, enum virDomainMemoryFlags flags);
That is ugly, it's also wrong, it break API and ABI compatibility, forget about it !
Let me know your idea about this.
If more C was implemented with defensive programming, and if people didn't broke API every time they think "it would be nicer" then it would be way easier to actually develop in C ! Please change your mindset that just doesn't work in the long term, sorry ... Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/