On 12/16/2013 04:32 PM, Michal Privoznik wrote:
On 11.12.2013 10:16, Michal Privoznik wrote:
Right now it's possible to start an interface that is already running, or destroy an interface multiple times. Such state transitions are not allowed and we check for such cases explicitly in other areas like qemu driver.
Michal Privoznik (2): interface: Introduce netcfInterfaceObjIsActive interface: Take interface status into account when starting and destroying
src/interface/interface_backend_netcf.c | 77 +++++++++++++++++++++++---------- 1 file changed, 53 insertions(+), 24 deletions(-)
So it seems to me like we have agreement that the current state transitions should be prohibited.
So I guess absence of protest is considered agreement? :-) Yeah, I suppose I can live with it. Dan does have a point that the current situation (although it is reproducing the initscripts behavior) is overloading a single API with multiple behaviors.
If that's the case, can somebody please review the patches? Thanks!
I'll look through them now.