Re: [libvirt] [Libvirt-announce] Candidate release 2 for libvirt-1.1.0
On 28/06/2013, at 3:05 PM, Daniel P. Berrange wrote:
On Fri, Jun 28, 2013 at 03:01:58PM +0100, Justin Clift wrote:
<snip>
> Googling shows IF_MAXUNIT in context of FreeBSD stuff. Not sure
> of the right approach here. eg exclude compiling this on OSX,
> or alternatively make-it-work on OSX.
Yes, this is from code that is only designed to work on FreeBSD. I
guess the OS-X BSD base isn't close enough to support this properly.
Try this patch
diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c
index 265676c..4e2f32a 100644
--- a/src/util/virnetdevtap.c
+++ b/src/util/virnetdevtap.c
@@ -275,7 +275,7 @@ cleanup:
VIR_FORCE_CLOSE(fd);
return ret;
}
-#elif defined(SIOCIFCREATE2) && defined(SIOCIFDESTROY)
+#elif defined(SIOCIFCREATE2) && defined(SIOCIFDESTROY) &&
defined(IF_MAXUNIT)
int virNetDevTapCreate(char **ifname,
int *tapfd,
int tapfdSize,
Thanks Dan, that works well. Libvirt is now compiling, and virsh
seems to be working happily (with a minimal amount of testing
anyway). :)
Regards and best wishes,
Justin Clift
--
Open Source and Standards @ Red Hat
twitter.com/realjustinclift