On Tue, Aug 08, 2017 at 02:09:17PM +0200, Andrea Bolognani wrote:
On Mon, 2017-08-07 at 14:38 +0100, Daniel P. Berrange wrote:
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/Makefile.am | 2 +- src/keycodemapdb | 2 +- src/util/virkeycode.c | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-)
The changes look sane, but the test suite is not happy:
$ VIR_TEST_DEBUG=1 ./tests/virkeycodetest TEST: virkeycodetest 1) Keycode mapping ... Translating 259 from ATSET2 to ATSET3, got -1 want 55 FAILED
Seems unrelated to your changes though, perhaps a regression in keycodemapdb?
No, its a fix in keycodemapdb. A sheer good fortune, the scancodes we decided to test were incorrectly defined. So when we fixed the mappings in keycodemapdb, we broke the tests :-) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|