Re: [libvirt] [PATCH 1/2] Add multiiqn XML dump
On Tue, Jun 08, 2010 at 10:04:56AM -0400, Hugh O. Brock wrote:
On Tue, Jun 08, 2010 at 11:31:21AM +0100, Daniel P. Berrange wrote:
> On Tue, Jun 08, 2010 at 08:20:37PM +1000, Justin Clift wrote:
> > On 06/08/2010 06:40 PM, Daniel P. Berrange wrote:
> > <snip>
> > >For paranoia, we should probably use virBufferEscapeString() in this place
> >
> > Found virBufferEscapeString() in buf.c/h, but it's not listed on the API
> > Reference page on the website.
> >
> > Is it supposed to be?
>
> This is an internal use only API. Only things listed in include/libvirt
> are supposed to be documented in the API reference
Such things should have a place, though -- maybe the HACKING file?
Yes, but the HACKING file really needs to be split up into separate
pages under the Docs -> Internals section of the website. One page
couldbe the virBuffer APIs
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|