On Tue, Feb 03, 2009 at 03:44:03PM +0000, John Levon wrote:
On Tue, Feb 03, 2009 at 02:27:31PM +0000, Daniel P. Berrange wrote:
Allow no <source> for bridge interfaces
Historically, it was allowed to specify a bridge interface without a specific bridge source, in which case xend would choose one. Keep compatible with this behaviour.
ACK in principle, but this will allow the QEMU, OpenVZ & Xen XM drivers to potentially de-reference NULL when using the resulting parsed config since they assume that brname is compulsory for type=bridge.
I'll fix them up. Should the first two throw an error back? I'll also add a comment explaining why we let it through.
Yeah, they don't support the idea of a 'default' bridge - its just a (bad) artifact of Xen's vif-bridge script that really shouldn't be used if you want reliable guest configs. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|