Re: [libvirt] [PATCH 0/3] NEWS: Split releases by year

On Fri, 2015-10-16 at 09:47 +0200, Martin Kletzander wrote: > On Thu, Oct 15, 2015 at 04:12:07PM +0200, Andrea Bolognani wrote: > > As agreed, I've followed up with the cleanups by splitting > > the huge news.html.in file into separate, smaller files, > > one per year. > > > > Along with the split I've also included a fixed XSLT > > stylesheet so that we can start shipping a meaningful > > NEWS file again. > > I like it, it looks nice, there are just two issues here: > > 1) the NEWS file is not generated if I run 'make all', I don't know > whether that should or should not happen, so feel free to debate > me on that one, This was the case even before my changes and I don't think it's an issue, as the file gets generated during dist and ends up in the release archive.

Let me know if you think otherwise. > 2) syntax-check fails with this series, but that's not because there > would be anything wrong with the files you've added, it's just an > exclusion rule missing them. Thanks for spotting that, I will include your fix.

Cheers. -- Andrea Bolognani Software Engineer - Virtualization Team -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list