On 02/09/2014 01:10 PM, Roman Bogorodskiy wrote:
Reset line numbering on each input file in check-aclrules.pl. Otherwise it reports wrong line numbers in its error messages.
Signed-off-by: Yuri Myasoedov <ymyasoedov@yandex.ru>
Generally, we like to preserve git authorship to the original patch idea. Based on IRC, I clarified that Yuri wrote the patch, then Roman tested it. I was able to reproduce the bogus line numbers by deleting a line from qemuConnectGetType (currently line 1137 of qemu_driver.c), pre-patch the error complained about line 104704 (that's a lot of lines!), post-patch, it complained about 16501 (the line where qemuConnectGetType is registered as a driver callback function pointer). ACK and pushed with authorship fixed up. Congrats, Yuri, on your first patch, even if it took an indirect route into the tree :)
--- src/check-aclrules.pl | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/check-aclrules.pl b/src/check-aclrules.pl index f54b934..9151e6a 100755 --- a/src/check-aclrules.pl +++ b/src/check-aclrules.pl @@ -254,6 +254,8 @@ while (<>) { $brace += $count; $count = s/}//g; $brace -= $count; +} continue { + close ARGV if eof; }
exit $status;
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org