On Wed, Jul 17, 2013 at 11:51:11AM -0600, Eric Blake wrote:
Long lines are harder to read and harder to diff; in fact, if lines get too long (> 1000 bytes), it starts causing issues where git send-email refuses to send patches for the file. I've cleaned up the tests directory in the past (see commits bd6c46f, 3b750d1), but new long lines have been introduced in the meantime.
Victim files found with: $ wc -L tests/qemuxml2argvdata/*.args | sort -k1,1n \ | sed -n '/\b\(9[0-9]\|[1-9][0-9][0-9]\)\b/p'
* tests/qemuxml2argvdata/qemuxml2argv-*.args: Split lines of any file with content longer than 90 columns.
We've done this before & people keep introducing new violations. Time for a syntax check rule for tests/*/*.args Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|