Re: [libvirt] [PATCH 1/4] add a qemu-specific event register API, to passthough the new events come from qemu
On Wed, Jan 25, 2012 at 02:16:14PM -0700, Eric Blake wrote:
On 12/16/2011 09:58 AM, shaohef(a)linux.vnet.ibm.com wrote:
> From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
>
> Basically, this feature can go along with qemu monitor passthrough.
> That way, if we use new commands in the monitor that generate new events, we want
some way to receive those new events too.
>
> Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
> ---
> include/libvirt/libvirt-qemu.h | 27 ++++
> include/libvirt/libvirt.h.in | 2 +-
> src/conf/domain_event.c | 293 ++++++++++++++++++++++++++++++++++++++--
> src/conf/domain_event.h | 50 ++++++-
> src/driver.h | 14 ++
> src/libvirt-qemu.c | 189 ++++++++++++++++++++++++++
> src/libvirt_private.syms | 6 +
> src/libvirt_qemu.syms | 5 +
> 8 files changed, 571 insertions(+), 15 deletions(-)
Where do we stand on this series? It seems like something worth
including in 0.9.10; can we get it rebased to the latest libvirt so it
can get a good review?
Thanks for asking about this...
Shaohe is on vacation for two weeks so I will do my best to answer in his
absence. I believe the process of moving the event code into libvirt_qemu.so
had increased code size, complexity, and duplication. He is still looking at
improving the series and will be posting another RFC soon after he returns from
vacation. Therefore, we'll have to punt this one to the next release.
--
Adam Litke <agl(a)us.ibm.com>
IBM Linux Technology Center