13 May
2008
13 May
'08
9:44 a.m.
Daniel P. Berrange wrote:
On Tue, May 13, 2008 at 01:29:35PM +0900, Atsushi SAKAI wrote:
Hi, Dan
I think the qemu_driver should check KVM_API_VERSION for SMP support. How do you think? I am worrying about MAX_VCPUS=16 changes to 32 in future.
If it increases to 32, then we should certainly check based on something like KVM_API_VERSION. I just don't think its worth checking for the ancient versions which only support 1 cpu because no one will be seriously using them.
It's worth noting that kvm-60 in f8 doesn't support 16 vcpus, it only supports 4. 16 vcpu support is only present in kvm-62 and later. So if this is ever backported to f8 and kvm isn't updated, we just replace one bug with another. - Cole