Re: [libvirt] [PATCH] bhyve: fix virObjectUnlock() usage
Eric Blake wrote:
On 05/17/2014 01:44 PM, Roman Bogorodskiy wrote:
> In a number of places in the bhyve driver, virObjectUnlock()
> is called with an arg without check if the arg is non-NULL, which
> could result in passing NULL value and a warning like:
>
> virObjectUnlock:340 : Object 0x0 ((unknown)) is not a virObjectLockable instance
Doesn't this instead argue that we should fix virObjectUnlock to
gracefully handle a NULL parameter, rather than making every caller uglier?
Calling it with NULL seems to be harmless anyway and the only problem
is this annoying warning.
So, what you propose is checking explicitly for NULL in
virObjectUnlock before we do virObjectIsClass(), and if the passed
argument is NULL indeed, just return, without logging anything about
that?
BTW, that's going to be a vast change, quick grep shows more than 750
calls of that function.
Roman Bogorodskiy
Attachments:
- attachment.sig (application/pgp-signature — 488 bytes)